Add alert data to JSON file in Case thread, remove Raw Data button #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Raw Databutton from the Case thread and moves the alert JSON into a JSON file in a subsequent message in the thread. It does not appear to be possible to include the JSON file in the message whereRaw Datawas. I tested this locally by running through the signal instance creation flow via the/signal_instancesAPI view.This change makes the alert data more visible, adds syntax highlighting, and allows for larger alert JSON sizes (the Raw Data modal view was constrained to 2500 characters.