Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display active roles in CaseParticipantsTab component, add Vitest, and unit test(s) #2960

Merged
merged 11 commits into from
Feb 9, 2023

Conversation

wssheldon
Copy link
Contributor

@wssheldon wssheldon commented Feb 8, 2023

This PR prevents renounced roles from being displayed in the CaseParticipantsTab component. Previously, when someone has frequently changed roles, their roles will appear as `('Reporter', 'Assignee', 'Participant', 'Assignee'), for example. We only display roles that haven't been renounced and add support for testing Vue 2 components with Vitest [0]. Finally, we add a unit test for this specific case and others for the CaseParticipantsTab component.

 ✓ tests/participants-tab.spec.js (2)

 Test Files  1 passed (1)
      Tests  2 passed (2)
   Start at  08:36:41
   Duration  778ms (transform 211ms, setup 0ms, collect 191ms, tests 14ms)


 PASS  Waiting for file changes...
       press h to show help, press q to quit

[0] https://vitest.dev/

@wssheldon wssheldon added enhancement New feature or request tests UI/UX javascript Pull requests that update Javascript code labels Feb 8, 2023
@wssheldon
Copy link
Contributor Author

@kevgliss @mvilanova Any opinions on where the tests for front-end should be stored? Here they are stored in the static/ dir and E2E tests are currently in the gitroot tests/ dir. Which do you prefer?

@wssheldon wssheldon merged commit 470e36c into master Feb 9, 2023
@wssheldon wssheldon deleted the ui/active-roles branch February 9, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code tests UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants