Skip to content

Commit

Permalink
media: mdp3: Fix resource leaks in of_find_device_by_node
Browse files Browse the repository at this point in the history
[ Upstream commit 35ca8ce ]

Use put_device to release the object get through of_find_device_by_node,
avoiding resource leaks.

Signed-off-by: Lu Hongfei <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
  • Loading branch information
Lu Hongfei authored and gregkh committed Sep 23, 2023
1 parent a9d6539 commit fa48112
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
Original file line number Diff line number Diff line change
Expand Up @@ -892,11 +892,13 @@ static int mdp_get_subsys_id(struct mdp_dev *mdp, struct device *dev,
ret = cmdq_dev_get_client_reg(&comp_pdev->dev, &cmdq_reg, index);
if (ret != 0) {
dev_err(&comp_pdev->dev, "cmdq_dev_get_subsys fail!\n");
put_device(&comp_pdev->dev);
return -EINVAL;
}

comp->subsys_id = cmdq_reg.subsys;
dev_dbg(&comp_pdev->dev, "subsys id=%d\n", cmdq_reg.subsys);
put_device(&comp_pdev->dev);

return 0;
}
Expand Down

0 comments on commit fa48112

Please sign in to comment.