Skip to content

Commit

Permalink
selftests/powerpc: Add checks for transactional sigreturn
Browse files Browse the repository at this point in the history
This is a new test case that creates a signal and starts a suspended
transaction inside the signal handler.

It returns from the signal handler with the CPU at suspended state, but
without setting user context MSR Transaction State (TS) field.

The kernel signal handler code should be able to handle this discrepancy
instead of crashing.

This code could be compiled and used to test 32 and 64-bits signal
handlers.

Signed-off-by: Breno Leitao <[email protected]>
Signed-off-by: Gustavo Romero <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
  • Loading branch information
leitao authored and mpe committed Dec 21, 2018
1 parent 6f5b9f0 commit 34642d7
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 1 deletion.
1 change: 1 addition & 0 deletions tools/testing/selftests/powerpc/tm/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ tm-signal-context-chk-fpu
tm-signal-context-chk-gpr
tm-signal-context-chk-vmx
tm-signal-context-chk-vsx
tm-signal-sigreturn-nt
tm-vmx-unavail
tm-unavailable
tm-trap
Expand Down
2 changes: 1 addition & 1 deletion tools/testing/selftests/powerpc/tm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ SIGNAL_CONTEXT_CHK_TESTS := tm-signal-context-chk-gpr tm-signal-context-chk-fpu

TEST_GEN_PROGS := tm-resched-dscr tm-syscall tm-signal-msr-resv tm-signal-stack \
tm-vmxcopy tm-fork tm-tar tm-tmspr tm-vmx-unavail tm-unavailable tm-trap \
$(SIGNAL_CONTEXT_CHK_TESTS) tm-sigreturn
$(SIGNAL_CONTEXT_CHK_TESTS) tm-sigreturn tm-signal-sigreturn-nt

top_srcdir = ../../../../..
include ../../lib.mk
Expand Down
46 changes: 46 additions & 0 deletions tools/testing/selftests/powerpc/tm/tm-signal-sigreturn-nt.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// SPDX-License-Identifier: GPL-2.0
/*
* Copyright 2018, Breno Leitao, Gustavo Romero, IBM Corp.
*
* A test case that creates a signal and starts a suspended transaction
* inside the signal handler.
*
* It returns from the signal handler with the CPU at suspended state, but
* without setting usercontext MSR Transaction State (TS) fields.
*/

#define _GNU_SOURCE
#include <stdlib.h>
#include <signal.h>

#include "utils.h"

void trap_signal_handler(int signo, siginfo_t *si, void *uc)
{
ucontext_t *ucp = (ucontext_t *) uc;

asm("tbegin.; tsuspend.;");

/* Skip 'trap' instruction if it succeed */
ucp->uc_mcontext.regs->nip += 4;
}

int tm_signal_sigreturn_nt(void)
{
struct sigaction trap_sa;

trap_sa.sa_flags = SA_SIGINFO;
trap_sa.sa_sigaction = trap_signal_handler;

sigaction(SIGTRAP, &trap_sa, NULL);

raise(SIGTRAP);

return EXIT_SUCCESS;
}

int main(int argc, char **argv)
{
test_harness(tm_signal_sigreturn_nt, "tm_signal_sigreturn_nt");
}

0 comments on commit 34642d7

Please sign in to comment.