Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support vector front/back #702

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Support vector front/back #702

merged 6 commits into from
Oct 3, 2023

Conversation

anthony-santana
Copy link
Collaborator

Description

Closes #645

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 27, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

schweitzpgi
schweitzpgi reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not want to put a Load here. These functions actually return references which are memory addresses rather than the value at the memory address. Internal to the compiler that means effectively there is no difference between

  T& foo();
  T* foo();

in terms of implementation. Both return a memory address. The first does have implicit dereferencing, but that is syntactic sugar that doesn't affect the implementation here.

lib/Frontend/nvqpp/ConvertExpr.cpp Outdated Show resolved Hide resolved
lib/Frontend/nvqpp/ConvertExpr.cpp Outdated Show resolved Hide resolved
@anthony-santana anthony-santana force-pushed the ast_vector branch 5 times, most recently from f3d1621 to 469e547 Compare October 2, 2023 18:53
@anthony-santana anthony-santana marked this pull request as ready for review October 2, 2023 19:38
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 2, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 2, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 2, 2023
@cuda-quantum-bot
Docs preview for PR #702.
0f74792
schweitzpgi
schweitzpgi approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Anthony.

@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 3, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
@cuda-quantum-bot
Docs preview for PR #702.
3582133
@anthony-santana anthony-santana enabled auto-merge (squash) October 3, 2023 18:36
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 3, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
@cuda-quantum-bot
Docs preview for PR #702.
8f8fdba
@anthony-santana
initial implementation
611dcd9 
Signed-off-by: A.M. Santana <[email protected]>
@anthony-santana
remove assert
57b83f7 
Signed-off-by: A.M. Santana <[email protected]>
@anthony-santana
woring front/back
0efc816 
Signed-off-by: A.M. Santana <[email protected]>
@anthony-santana
pr comments and proper filecheck test for front back
bb10438 
Signed-off-by: A.M. Santana <[email protected]>
@anthony-santana
clang format
63be041 
Signed-off-by: A.M. Santana <[email protected]>
@anthony-santana
check dags
23fda3f 
Signed-off-by: A.M. Santana <[email protected]>
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Oct 3, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana anthony-santana merged commit c69729b into NVIDIA:main Oct 3, 2023
109 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
@anthony-santana anthony-santana deleted the ast_vector branch October 3, 2023 23:09
@bettinaheim bettinaheim added this to the release 0.5.0 milestone Nov 15, 2023
@bettinaheim bettinaheim changed the title Support vector front/back in bridge Support vector front/back Nov 15, 2023
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Milestone
release 0.5.0
Development

Successfully merging this pull request may close these issues.

Support lowering of std::vector::front and std::vector::back
3 participants
@anthony-santana @schweitzpgi @bettinaheim