[Opt] Fix use after free (erase) in mem2reg #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
approved these changes
Sep 8, 2023
|
Thanks for fixing the bug, Bruno. |
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
boschmitt
force-pushed
the
mem2reg_fix
branch
from
a70290e
to
f9d897b
Compare
Command Bot: Processing... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pass collects operations to clean up in one container and use two loops to erase different kinds. The problem is that the first loop was erasing operations while leaving their pointers. Then, the second loop would try to cast the erased operations of those pointers and the garbage.
This PR simply changes the behavior to first drop all uses of the operations and, on a third loop, actually to the erasing.