Throw runtime error if job fails on IonQ's server #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amccaskey
reviewed
Jul 17, 2023
runtime/cudaq/platform/default/rest/helpers/ionq/IonQServerHelper.cpp
Outdated
Show resolved
Hide resolved
amccaskey
reviewed
Jul 17, 2023
anthony-santana
force-pushed
the
ionq_fail_error
branch
from
5937802
to
86815b5
Compare
amccaskey
approved these changes
Jul 18, 2023
Signed-off-by: A.M. Santana <[email protected]>
Signed-off-by: A.M. Santana <[email protected]>
anthony-santana
force-pushed
the
ionq_fail_error
branch
from
86815b5
to
78ea89b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We weren't previously checking for a "failed" status from the IonQ jobs. This meant the terminal would hang indefinitely without informing the user of the error.
Changes