Add enumerated noise_model_type to noise interface #2200
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amccaskey
reviewed
Oct 1, 2024
| noise_model_type noise_type = noise_model_type::unknown; | ||
|
|
||
| /// @brief Noise probability | ||
| real probability = 0.0; |
There was a problem hiding this comment.
Do we envision a need for multiple noise parameters?
There was a problem hiding this comment.
Do we envision a need for multiple noise parameters?
Yes, I suppose that could happen for some future noise models. For example, if we wanted to mimic the PAULI_CHANNEL_1 noise option from Stim, then that would need multiple parameters. Do you think we should change probability to a vector of doubles?
There was a problem hiding this comment.
Yea I think that would be a good idea, maybe call it parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #2193 but will require additional review.