Refactor python kernel #2024
Closed
Refactor python kernel #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing redundant overloaded methods * Using ternary conditional operator * Using set for constant lookup * Using np function to check for normalization
* Optimizing control loop * Using textwrap to remove leading spaces from the source code
|
Just a recommendation ... it would probably be best to hold off on requesting reviews until a PR passes the CI. Otherwise, people will likely have to re-review it once additional changes are applied. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
force-pushed
the
refactor_python_kernel
branch
from
5537c75
to
9c1c7b5
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
Closing this for now. Will be drafting one file at a time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring kernel_builder and kernel_decorator