NVQC Optimizations for VQE (C++ and Python) #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new way allows for something like this:
cudaq::gradients::central_difference gradient(ansatz, n_qubits, n_layers);
Instead of something like this:
auto argMapper = [&](std::vector<double> x) {
return std::make_tuple(x, n_qubits, n_layers);
};
cudaq::gradients::central_difference gradient(ansatz, argMapper);
sacpis
reviewed
Jul 8, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
commented
Jul 11, 2024
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
reviewed
Jul 15, 2024
sacpis
reviewed
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes optimizes VQE performance when running simulations on NVQC.
NOTE: This change will only take effect once this functionality is supported/deployed within NVQC.
See also #1824 (not yet supported in the service)
The changes work for both C++ and Python applications.
Notable changes:
cudaq::vqe()to be invoked with variadic arguments similar to how we invokecudaq::sample()andcudaq::observe(). More specifically, that means that we allow the user to pass the concrete, non-variational arguments (the arguments not subject to VQE optimization) directly into thecudaq::vqe()call. Users must switch to this calling convention to achieve notable speedups.startingArgIdxparameter that is typically set to 1 for these remove VQE applications. The motivation for this is that we do not wish to synthesize all of the arguments when submitting to NVQC because we want the server to be able to repeatedly invoke the VQE kernel with different variational parameters while executing VQE.startingArgIdxparameter so that, like above, we can pack concrete arguments into a member buffer for all arguments except the firststartingArgIdxarguments. This change is similarly required so that the NVQC server can repeatedly invoke the kernel with different variational parameters.cudaq.vqe()+ argMappers to achieve the same thing that the variadic arguments in C++ offer. Most of our previous examples already did this, so I don't think that Python users would have to do anything special to their code to achieve these faster NVQC speeds.I believe this PR is NOT a breaking change, but please let me know if anybody sees anything that suggests otherwise. Users will need to use the new variadic argument substitution for
cudaq::vqe()in order to achieve faster speeds.