Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficient bucketing #49

Merged
merged 8 commits into from
Sep 29, 2018
Merged

Efficient bucketing #49

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d1b37f
beautiful
definitelynotmcarilli Sep 26, 2018
796dc0a
IT'S WORKING
definitelynotmcarilli Sep 26, 2018
5fda4ce
Hopefully fix race condition for fallback hook
definitelynotmcarilli Sep 26, 2018
ad73dd6
Updating test
definitelynotmcarilli Sep 26, 2018
87b5a8f
shared_param -> delayed_allreduce
definitelynotmcarilli Sep 28, 2018
02ad9fd
Adding a safety check
definitelynotmcarilli Sep 28, 2018
eb697be
One more check
definitelynotmcarilli Sep 29, 2018
09f8066
syntax...
definitelynotmcarilli Sep 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
syntax...
  • Loading branch information
@definitelynotmcarilli
definitelynotmcarilli committed Sep 29, 2018
commit 09f80664df66ce0eee047dbd5c08f15e25e5b0eb
4 changes: 2 additions & 2 deletions apex/parallel/distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ def overlapping_backward_epilogue():

# Sanity checks that all the buckets were kicked off
if self.next_bucket != self.num_buckets:
raise RuntimeError("In epilogue, next_bucket != num_buckets. This probably indicates ")
"some buckets were not allreduced.")
raise RuntimeError("In epilogue, next_bucket != num_buckets. "
"This probably indicates some buckets were not allreduced.")

for actual, expected in zip(self.buckets_ready_size, self.bucket_sizes):
if actual != expected:
Expand Down