-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove access to contiguous TL buffer from Coco Reader tests #3351
Conversation
Signed-off-by: Krzysztof Lecki <[email protected]>
!build |
CI MESSAGE: [3004698]: BUILD STARTED |
shape[sample_idx].num_elements() * sizeof(int)); | ||
out_ptr += shape[sample_idx].num_elements(); | ||
} | ||
cudaStreamSynchronize(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need that. You are using pagable memory in the copy so it syncs by definition.
boxes_shape[sample_idx].num_elements() * sizeof(float)); | ||
boxes_ptr += boxes_shape[sample_idx].num_elements(); | ||
} | ||
cudaStreamSynchronize(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
labels_shape[sample_idx].num_elements() * sizeof(int)); | ||
labels_ptr += labels_shape[sample_idx].num_elements(); | ||
} | ||
cudaStreamSynchronize(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again
vertices_shape[sample_idx].num_elements() * sizeof(float)); | ||
vertices_ptr += vertices_shape[sample_idx].num_elements(); | ||
} | ||
cudaStreamSynchronize(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
CI MESSAGE: [3004698]: BUILD PASSED |
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
…3351) Introduce sample-by-sample copies. Signed-off-by: Krzysztof Lecki <[email protected]>
Description
What happened in this PR
Remove access to contiguous TL buffer from Coco Reader tests.
Introduce sample-by-sample copies.
Additional information
Affected modules and functionalities:
Coco reader tests
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A