Adjust examples to new readers module #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jantonguirao
approved these changes
Feb 25, 2021
| @@ -34,7 +34,7 @@ | |||
| "source": [ | |||
| "used `batch_size` is `1`, to keep things simple.\n", | |||
| "\n", | |||
| "2. Next, let's implement the pipeline. Firstly, we need to load data from disk (or any other source). FileReader is able to load data, as well as it's labels. For more information, refer to FileReader docs. Furthermore, similarly to image data, you can use Reader operators that are specific for a given dataset or a dataset format (see [CaffeReader](https://docs.nvidia.com/deeplearning/sdk/dali-developer-guide/docs/supported_ops.html#nvidia.dali.ops.CaffeReader)). After loading the input data, the pipeline decodes the audio data. As stated above, the AudioDecoder operator is able to decode most of the well-known audio formats.\n", | |||
| "2. Next, let's implement the pipeline. Firstly, we need to load data from disk (or any other source). readers.File is able to load data, as well as it's labels. For more information, refer to readers.File docs. Furthermore, similarly to image data, you can use Reader operators that are specific for a given dataset or a dataset format (see [readers.Caffe](https://docs.nvidia.com/deeplearning/sdk/dali-developer-guide/docs/supported_ops_legacy.html#nvidia.dali.ops.readers.Caffe)). After loading the input data, the pipeline decodes the audio data. As stated above, the AudioDecoder operator is able to decode most of the well-known audio formats.\n", | |||
There was a problem hiding this comment.
FYI: We are going to rewrite this with the functional API. It can stay like this for now, but most likely we are going to change it very soon.
| @@ -189,7 +189,7 @@ | |||
| "source": [ | |||
| "## Using Dali\n", | |||
| "### Define the Pipeline. \n", | |||
| "For advanced usage, refer to SequenceReader and VideoReader docs." | |||
| "For advanced usage, refer to readers.Sequence and readers.Video docs." | |||
There was a problem hiding this comment.
perhaps out of scope but I'll write it here for the record. We should probably add links to the operator documentation when mentioning operators in the examples.
There was a problem hiding this comment.
Certainly out of scope. There is a lot of those mentions, it would be a really tedious task. (not like this isn't). Nonetheless good idea.
| @@ -47,7 +47,7 @@ | |||
| "cell_type": "markdown", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "We need some video containers to process. We can use [Sintel](https://en.wikipedia.org/wiki/Sintel) trailer, which is an mp4 container containing an h264 video and distributed under the Create Common license. Let's split it into 10s clips in order to check how `VideoReader` handles mutliple video files. This can be done easily with the `ffmpeg` standalone tool. `DALI_EXTRA_PATH` environment variable should point to the place where data from [DALI extra repository](https://github.com/NVIDIA/DALI_extra) is downloaded. Please make sure that the proper release tag is checked out. The snippet below verifies, that you have defined `DALI_extra` path as an environment variable." | |||
| "We need some video containers to process. We can use [Sintel](https://en.wikipedia.org/wiki/Sintel) trailer, which is an mp4 container containing an h264 video and distributed under the Create Common license. Let's split it into 10s clips in order to check how `readers.Video` handles mutliple video files. This can be done easily with the `ffmpeg` standalone tool. `DALI_EXTRA_PATH` environment variable should point to the place where data from [DALI extra repository](https://github.com/NVIDIA/DALI_extra) is downloaded. Please make sure that the proper release tag is checked out. The snippet below verifies, that you have defined `DALI_extra` path as an environment variable." | |||
There was a problem hiding this comment.
Suggested change
| "We need some video containers to process. We can use [Sintel](https://en.wikipedia.org/wiki/Sintel) trailer, which is an mp4 container containing an h264 video and distributed under the Create Common license. Let's split it into 10s clips in order to check how `readers.Video` handles mutliple video files. This can be done easily with the `ffmpeg` standalone tool. `DALI_EXTRA_PATH` environment variable should point to the place where data from [DALI extra repository](https://github.com/NVIDIA/DALI_extra) is downloaded. Please make sure that the proper release tag is checked out. The snippet below verifies, that you have defined `DALI_extra` path as an environment variable." | |
| "We need some video containers to process. We can use [Sintel](https://en.wikipedia.org/wiki/Sintel) trailer, which is an mp4 container containing an h264 video and distributed under the Create Common license. Let's split it into 10s clips in order to check how `readers.Video` handles multiple video files. This can be done easily with the `ffmpeg` standalone tool. `DALI_EXTRA_PATH` environment variable should point to the place where data from [DALI extra repository](https://github.com/NVIDIA/DALI_extra) is downloaded. Please make sure that the proper release tag is checked out. The snippet below verifies, that you have defined `DALI_extra` path as an environment variable." |
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
klecki
force-pushed
the
readers-notebooks
branch
from
e5bca8a
to
136757f
Compare
banasraf
approved these changes
Feb 25, 2021
|
!build |
|
CI MESSAGE: [2109185]: BUILD STARTED |
|
CI MESSAGE: [2109185]: BUILD PASSED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
Refactor examples to use new readers module.
What happened in this PR?
Find & replace
IPython notebooks
N/a
👀
This is refactoring of examples.
JIRA TASK: [DALI-1866]