migrated base runtime to core #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
karlhigley
reviewed
Jul 11, 2023
| @@ -23,6 +23,7 @@ | |||
| from google.protobuf import text_format | |||
|
|
|||
| from merlin.dag import postorder_iter_nodes | |||
| from merlin.dag.base_runtime import Runtime | |||
There was a problem hiding this comment.
I don't really like the convention where the names of classes and packages start with "base." We were kind of painted into a corner with Operator vs BaseOperator, since Operator already existed and historically was the base class of all operators, but I'm thinking maybe the subpackage in Core should be called runtimes so this reads as from merlin.dag.runtimes import Runtime
There was a problem hiding this comment.
You good with making this change in a subsequent PR? If not we need to merge NVIDIA-Merlin/core#359 first.
…rm-base-runtime
karlhigley
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires core PR: NVIDIA-Merlin/core#358
We are migrating the base runtime to the core library. This is done in an effort to consolidate how graphs are executed. We want to move the framework to where both nvtabular workflows and ensembles use runtimes. This will allow us to simplify the framework to only use one mechanism for execution.