Remove InferenceNode after migrating its functionality into the Node class from Merlin Core
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
karlhigley
reviewed
Jul 6, 2023
| # Make a new subclass of InferenceOperator so the mocks don't interfere with other tests. | ||
| class InferenceOperatorWithModelPath(InferenceOperator): | ||
| pass | ||
| # Make a new subclass of BaseOperator so the mocks don't interfere with other tests. |
There was a problem hiding this comment.
This will make the test pass, but now this functionality only exists in the tests. Unless we can figure out a way to put it the non-test code, we might just want to drop it for now. Writing out the actual code in the method every time you want to do this isn't great, but it's not that much and we can come back to this to make it more convenient once we have a better handle on how model registries should integrate with the rest of Merlin.
karlhigley
approved these changes
Jul 6, 2023
karlhigley
changed the title
InferenceNode after migrating its functionality into the Node class from Merlin Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the inference node and operator and moves the model registry apparatus to core. Now all operators are either base operator or stat operator. This is the first step in making all operators work in workflows and ensembles alike.
This PR requires the following core PR: NVIDIA-Merlin/core#357