Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Hyrax hiding again #43

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Make Hyrax hiding again #43

merged 3 commits into from
Nov 13, 2023

Conversation

Antonio95
Copy link

Description

As discussed, I have reverted back to its original definition by removing the evaluation-commitment randomness from the proof and ignoring the claimed-value argument in check. Tests pass.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Antonio95 Antonio95 changed the base branch from master to hyrax-pcs November 13, 2023 11:04
Copy link

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the input to check be changed to:
_values: impl IntoIterator<Item = G::ScalarField>, since now the value is ignored?

@Antonio95
Copy link
Author

Shouldn't the input to check be changed to: _values: impl IntoIterator<Item = G::ScalarField>, since now the value is ignored?

Indeed, I've fixed it now. No warning was produced before because I was still zipping it - which was not needed. Thank you, good catch.

Copy link

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmagician mmagician merged commit 7c7328d into hyrax-pcs Nov 13, 2023
4 checks passed
@mmagician mmagician deleted the hyrax-hiding branch November 13, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants