Custom DOI field in load_csv
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to load the Retraction Watch csv database. An example of that format is provided with the test case.
|
LGTM! Not sure why the SemanticScholar tests fail, they seem to run fine on the CI To use this change, install the dev version of litstudy: pip install git+https://github.com/NLeSC/litstudy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom DOI field option to load custom format CSVs. Added a test case for this as well.
In addition, a minor bug with calling strptime is fixed (it called the module, not the class inside the module which holds the method).
Tests pass on my machine, except two Semantic Scholar tests. I didn't touch that part, so I assume those failures are unrelated.