Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_interpolate_range format writing issue #504

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

Benjamin-Gunn
Copy link
Collaborator

Description:

Fixes a bug when running model_mod_check with a 3D sphere model, where test 5 would result in an error due to the formatting of three write statements in test_interpolate_range_threed_sphere.f90.

Fixes issue

Fixes #487

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Tested with panda_models branch on achauphan@8ed5a96

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Changes  test_interpolate_range_threed_sphere to prevent an error from formatting while writing to the screen.
Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for the fix @Benjamin-Gunn

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jun 26, 2023
@hkershaw-brown hkershaw-brown merged commit c9ff9ff into NCAR:main Jun 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: test_interpolate_range incorrectly outputting an integer type for various interp_test variables
2 participants