Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update POA Node URL #1986

Merged
merged 4 commits into from
Jul 2, 2018
Merged

Update POA Node URL #1986

merged 4 commits into from
Jul 2, 2018

Conversation

rstormsf
Copy link
Contributor

@rstormsf rstormsf commented Jun 26, 2018

Closes #1984

I tried to deploy it on Github Pages, but I couldn't figure out how to append /myownURL to all paths, so I could use it for GH-pages

Tests:


Test Suites: 54 passed, 54 total
Tests:       803 passed, 803 total
Snapshots:   14 passed, 14 total
Time:        103.883s
Ran all test suites.
✨  Done in 106.25s.

@ghost
Copy link

ghost commented Jun 26, 2018

@rstormsf Wow, how come infura support POA Network?? Amazing

@dternyak dternyak changed the title Closes #1984. Change POA.network RPC endpoint to Poa.Infura.io Update POA Node URL Jun 26, 2018
@dternyak
Copy link
Contributor

@rstormsf FYI, you can use mycryptobuilds to test commits like so https://mycryptobuilds.com/130fd3e1088cb62f64e5477ee5709aa263073c65

@dternyak
Copy link
Contributor

I'm getting a mismatch on balances when using a test address via view-only. @rstormsf Mind helping to understand what the discrepancy is caused by?

screen shot 2018-06-27 at 12 29 28 am

https://poaexplorer.com/address/0x99a39d3a0f3237bb055c826cdc94d5a7ff5d8493

@rstormsf
Copy link
Contributor Author

@dternyak ??

image

I don't see any issues

@rstormsf
Copy link
Contributor Author

@dternyak
MEW has merged:
MyEtherWallet/etherwallet#1926

@dternyak
Copy link
Contributor

@rstormsf I'm still getting issues on mycryptobuilds. Any ideas on how to debug?

@rstormsf
Copy link
Contributor Author

rstormsf commented Jun 27, 2018

@dternyak I can also see the MyCrypto receives 400 errors while
https://rstormsf.github.io/etherwallet/ - works just fine

why does

https://mycryptobuilds.com/130fd3e1088cb62f64e5477ee5709aa263073c65

repeatedly trying to make a connection to http://localhost:8545 ?

I sent an email to infura to ask for help to resolve this issue

image

I'd assume it's mycrypto is trying to do something weird or my PR is not being done correctly.

I can see it made a request to infura's API and received 200, but for some unknown reason it makes localhost requests which it shouldn't do.

@rstormsf
Copy link
Contributor Author

rstormsf commented Jun 28, 2018

@dternyak
Infura has confirmed the issue from their end.
Awaiting the resolution

@rstormsf
Copy link
Contributor Author

@dternyak
update on the issue:
Infura has found the problem that with every request, they are rejecting id field if it's string, allowing only integers to accept. They are working on a fix to accept both types strings and number when you send JSONRPC request.

I will let you know when they fixed it.

Thank you for waiting

@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.112% when pulling 115d2db on rstormsf:develop into ecb9aca on MyCryptoHQ:develop.

@rstormsf
Copy link
Contributor Author

rstormsf commented Jun 29, 2018

@dternyak it seems like I changed type to infura instead of rpc and now everything is working fine in my last commit:

https://mycryptobuilds.com/115d2db8ba3afbff5aad5795db2b6f6839b2036c/#/account/info

+      type: 'infura',

I guess somewhere you use integers for sending JSONRPC id param for this type and that's why it's working

@rstormsf
Copy link
Contributor Author

rstormsf commented Jul 2, 2018

@dternyak ping

@dternyak
Copy link
Contributor

dternyak commented Jul 2, 2018

Tested, can confirm the fix. Looks good to merge.

@dternyak dternyak merged commit a3a9250 into MyCryptoHQ:develop Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants