Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved mountain mask #252

Merged
merged 2 commits into from
Oct 9, 2017
Merged

improved mountain mask #252

merged 2 commits into from
Oct 9, 2017

Conversation

MM1nd
Copy link
Contributor

@MM1nd MM1nd commented Oct 8, 2017

In absolute timing this takes about 10s off the clock for a 1024*512 map. Relative timings are dominated by anti-aliasing, but I thought I'd do this while waiting for #251 to be resolved.

Code is also a bit cleaner, once again.

Not much more to be said about this one.

@coveralls
Copy link

coveralls commented Oct 8, 2017

Coverage Status

Coverage increased (+0.1%) to 85.011% when pulling 99ed82f on MM1nd:mountains_mask into 20d93d9 on Mindwerks:master.

@codecov-io
Copy link

codecov-io commented Oct 8, 2017

Codecov Report

Merging #252 into master will increase coverage by 0.86%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #252      +/-   ##
=========================================
+ Coverage   79.64%   80.5%   +0.86%     
=========================================
  Files          28      28              
  Lines        3620    3617       -3     
  Branches      721     715       -6     
=========================================
+ Hits         2883    2912      +29     
+ Misses        547     511      -36     
- Partials      190     194       +4
Impacted Files Coverage Δ
worldengine/common.py 85.05% <100%> (+0.17%) ⬆️
worldengine/drawing_functions.py 80.8% <100%> (ø) ⬆️
worldengine/model/world.py 75% <100%> (+0.66%) ⬆️
worldengine/simulations/erosion.py 69.96% <0%> (+10.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d93d9...9d7d214. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 8, 2017

Coverage Status

Coverage increased (+1.0%) to 85.872% when pulling 9d7d214 on MM1nd:mountains_mask into 20d93d9 on Mindwerks:master.

@psi29a
Copy link
Member

psi29a commented Oct 9, 2017

Nice work! Those nested loops are gone which is a big win for simplicity. Thank you again. :)

@psi29a psi29a merged commit eec3895 into Mindwerks:master Oct 9, 2017
@MM1nd MM1nd deleted the mountains_mask branch October 9, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants