fix: do not assume images in postprocess_batch is a tensor #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2023 22:40
ljleb
changed the title
|
It seems that This should then work no matter which version of torch is installed. |
|
Thanks for the review! I wasn't sure if it was okay to merge for my own purposes 😅 |
|
Np. The PR passes web tests so I am confident that it does not break anything major. Also, can you take a look at #1802? I am not very familiar with ADetailer, but from the source code ADetailer is not trying to import anything directly from ControlNet. Why the behaviour changes after reload got removed? |
|
Sure I'll look into it. |
tiangles
pushed a commit
to diffus-me/sd-webui-controlnet
that referenced
this pull request
Aug 18, 2023
Co-authored-by: ljleb <set>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sd-webui-comfyui we need
imagesto be a list, so that each image in the list can have an arbitrary size, and so that the list size can change arbitrarily. It seems thatlen(tensor)is defined and equivalent totensor.shape[0].See AUTOMATIC1111/stable-diffusion-webui#11933 for details.