Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove importlib.reloads #1775

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Remove importlib.reloads #1775

merged 4 commits into from
Jul 8, 2023

Conversation

ljleb
Copy link
Collaborator

@ljleb ljleb commented Jul 8, 2023 •
edited
Loading

Note: this only works with webui>=1.4.0 and IIUC on recent versions of vlad's fork.

Remove importlib.reloads and move the contents of external_code.py to another location so that python caching works, even when it is imported from another extension using importlib.import_module

@ljleb ljleb requested a review from huchenlei July 8, 2023 06:15
ljleb and others added 2 commits July 8, 2023 02:20
huchenlei
huchenlei approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@huchenlei huchenlei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for cleaning it up.

Note: All web tests pass when checked locally.

scripts/external_code.py Show resolved Hide resolved
tests/external_code_api/importlib_reload_test.py Show resolved Hide resolved
@huchenlei huchenlei merged commit 6ed97a7 into Mikubill:main Jul 8, 2023
1 check passed
@ljleb ljleb deleted the no-reload branch July 8, 2023 20:57
@ljleb ljleb mentioned this pull request Jul 8, 2023
Closed
@huchenlei huchenlei mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljleb @huchenlei