fix bytes encoding #271
Merged
fix bytes encoding #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
reviewed
Sep 20, 2022
| @@ -174,7 +174,7 @@ function encodeField( | |||
| if (typeof value === 'number') { | |||
| value = numberToBuffer(value); | |||
| } else if (isHexString(value)) { | |||
| value = numberToBuffer(parseInt(value, 16)); | |||
There was a problem hiding this comment.
I believe (based on the comment in the PR that changed this) the change from Buffer.from to numberToBuffer was intentional, but I'm not sure why. @adonesky1 Would you be willing to elaborate on this?
There was a problem hiding this comment.
@mcmire this change was intentional. And apparently our testing was not sufficient to expose the regression here. This change was made in response to feedback provided here to a much larger set of changes in this suite of related functions. This change does seem to get us back on track. I am a bit concerned now however that there may be other regressions from this PR still lurking, since our test suite didn't catch this one...
adonesky1
approved these changes
Sep 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #270