feat: improve authentication parsing logic in http listener #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- credentials are always parsed - fix IN-USER matching for non CONNECT http proxy requests - fix authentication caching by including username in cache
This comment was marked as off-topic.
This comment was marked as off-topic.
wwqgtxx
force-pushed
the
Alpha
branch
2 times, most recently
from
cf3e4b1
to
5028667
Compare
xishang0128
force-pushed
the
Alpha
branch
3 times, most recently
from
760da02
to
0e22876
Compare
wwqgtxx
added a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1335