Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the UI less often when loading models for diffing #321

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

therealryan
Copy link
Collaborator

@therealryan therealryan commented Mar 31, 2023

Fixes #320, we're gating our previously per-loaded-flow UI updates to instead happen:

  • Every three seconds
  • When all flows for a model are loaded

Even with the small size of the example system model, you can seen an appreciable difference in loading speed between before and after this change

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@therealryan therealryan merged commit 0b79443 into main Mar 31, 2023
@therealryan therealryan deleted the diff_load_batch branch March 31, 2023 14:17
@therealryan therealryan added the enhancement New feature or request label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diff model loading batch UI update
1 participant