Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in User Guide #940

Merged

Conversation

anubh-v
Copy link
Contributor

@anubh-v anubh-v commented Oct 29, 2019

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X ] Documentation update
• [X ] Bug fix

Fixes #843
What is the rationale for this request?
To fix a broken link in the user guide.

What changes did you make? (Give an overview)
I replaced a link in userGuide/cliCommands.md.

Provide some example code that this change will affect:
N.A.
Is there anything you'd like reviewers to focus on?
N.A.

Testing instructions:
Manually verify the correctness of the new link using a locally generated copy of the site.

Proposed commit message: (wrap lines at 72 characters)

User Guide: Fix broken link to section on converting an existing wiki

There is a broken link in the explanation of the `init` command,
under the References section of the user guide.

Let's replace this link with the correct link, so information is
communicated effectively to users.

@anubh-v anubh-v changed the title [WIP] Fix broken link [WIP] Fix broken link in User Guide Oct 29, 2019
Copy link
Member

@yamgent yamgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR, your current changes looks good. 👍

May I know whether you are planning to add more changes? Am wondering because this PR is in draft mode...

@anubh-v anubh-v marked this pull request as ready for review October 30, 2019 16:16
@anubh-v
Copy link
Contributor Author

anubh-v commented Oct 30, 2019

Thanks @yamgent
I have nothing else to add, accidentally left this PR as a draft.

@anubh-v anubh-v changed the title [WIP] Fix broken link in User Guide Fix broken link in User Guide Oct 30, 2019
@yamgent yamgent merged commit 58aa947 into MarkBind:master Oct 31, 2019
@yamgent yamgent added this to the v2.5.4 milestone Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user guide: fix broken link to site conversion info
2 participants