Use poetry for dependency management #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsorros
reviewed
Jul 20, 2023
.github/workflows/test.yml
Outdated
| @@ -7,8 +7,16 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/setup-python@v4 | |||
| with: | |||
| python-version: "3.8" | |||
| python-version: "3.9" | |||
| - name: Cache dependencies | |||
There was a problem hiding this comment.
i think you can do
with:
- cache: 'poetry'
in the setup-python action
nsorros
reviewed
Jul 20, 2023
.github/workflows/test.yml
Outdated
| - name: Run tests | ||
| run: pytest | ||
| run: | | ||
| pip install poetry |
There was a problem hiding this comment.
i dont know if this can cause issue but i remember there was another default way to install
nsorros
reviewed
Jul 20, 2023
| @@ -130,7 +146,7 @@ Read our CONTRIBUTING.md then | |||
| Create a virtual environment and install the package | |||
|
|
|||
| ``` | |||
| make virtualenv | |||
| poetry install | |||
There was a problem hiding this comment.
we need to update the documentation we have created as well
nsorros
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows #68 and resolves #67. Relevant to #66. Switches to poetry for dependency management.
Checklist