removed get_parameters, replaced by direct call to inspect

manim/animation/speedmodifier.py

@@ -2,13 +2,12 @@
 
 from __future__ import annotations
 
+import inspect
 import types
 from typing import Callable
 
 from numpy import piecewise
 
-from manim.utils.simple_functions import get_parameters
-
 from ..animation.animation import Animation, Wait, prepare_animation
 from ..animation.composition import AnimationGroup
 from ..mobject.mobject import Mobject, Updater, _AnimationBuilder
@@ -260,8 +259,7 @@ def add_updater(
         :class:`.ChangeSpeed`
         :meth:`.Mobject.add_updater`
         """
-        parameters = get_parameters(update_function)
-        if "dt" in parameters:
+        if "dt" in inspect.signature(update_function).parameters:
             mobject.add_updater(
                 lambda mob, dt: update_function(
                     mob, ChangeSpeed.dt if ChangeSpeed.is_changing_dt else dt

manim/mobject/mobject.py

@@ -6,6 +6,7 @@
 
 
 import copy
+import inspect
 import itertools as it
 import operator as op
 import random
@@ -47,7 +48,6 @@
 from ..utils.exceptions import MultiAnimationOverrideException
 from ..utils.iterables import list_update, remove_list_redundancies
 from ..utils.paths import straight_path
-from ..utils.simple_functions import get_parameters
 from ..utils.space_ops import angle_between_vectors, normalize, rotation_matrix
 
 # TODO: Explain array_attrs
@@ -844,8 +844,7 @@ def update(self, dt: float = 0, recursive: bool = True):
         if self.updating_suspended:
             return self
         for updater in self.updaters:
-            parameters = get_parameters(updater)
-            if "dt" in parameters:
+            if "dt" in inspect.signature(updater).parameters:
                 updater(self, dt)
             else:
                 updater(self)
@@ -870,7 +869,10 @@ def get_time_based_updaters(self) -> list[Updater]:
         :meth:`has_time_based_updater`
 
         """
-        return [updater for updater in self.updaters if "dt" in get_parameters(updater)]
+        return [
+            updater for updater in self.updaters
+            if "dt" in inspect.signature(updater).parameters
+        ]
 
     def has_time_based_updater(self) -> bool:
         """Test if ``self`` has a time based updater.
@@ -886,7 +888,10 @@ def has_time_based_updater(self) -> bool:
         :meth:`get_time_based_updaters`
 
         """
-        return any("dt" in get_parameters(updater) for updater in self.updaters)
+        return any(
+            "dt" in inspect.signature(updater).parameters
+            for updater in self.updaters
+        )
 
     def get_updaters(self) -> list[Updater]:
         """Return all updaters.
@@ -979,7 +984,7 @@ def construct(self):
         else:
             self.updaters.insert(index, update_function)
         if call_updater:
-            parameters = get_parameters(update_function)
+            parameters = inspect.signature(update_function).parameters
             if "dt" in parameters:
                 update_function(self, 0)
             else:

manim/mobject/opengl/opengl_mobject.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import copy
+import inspect
 import itertools as it
 import random
 import sys
@@ -29,7 +30,6 @@
     uniq_chain,
 )
 from manim.utils.paths import straight_path
-from manim.utils.simple_functions import get_parameters
 from manim.utils.space_ops import (
     angle_between_vectors,
     normalize,
@@ -1375,7 +1375,7 @@ def get_family_updaters(self):
         return list(it.chain(*(sm.get_updaters() for sm in self.get_family())))
 
     def add_updater(self, update_function, index=None, call_updater=False):
-        if "dt" in get_parameters(update_function):
+        if "dt" in inspect.signature(update_function).parameters:
             updater_list = self.time_based_updaters
         else:
             updater_list = self.non_time_updaters

manim/renderer/shader.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import inspect
 import re
 import textwrap
 from pathlib import Path
@@ -9,7 +10,6 @@
 
 from .. import config
 from ..utils import opengl
-from ..utils.simple_functions import get_parameters
 
 SHADER_FOLDER = Path(__file__).parent / "shaders"
 shader_program_cache: dict = {}
@@ -199,7 +199,7 @@ def get_updaters(self):
         return self.time_based_updaters + self.non_time_updaters
 
     def add_updater(self, update_function, index=None, call_updater=True):
-        if "dt" in get_parameters(update_function):
+        if "dt" in inspect.signature(update_function).parameters:
             updater_list = self.time_based_updaters
         else:
             updater_list = self.non_time_updaters

manim/utils/simple_functions.py

@@ -6,7 +6,6 @@
     "binary_search",
     "choose",
     "clip",
-    "get_parameters",
     "sigmoid",
 ]
 
@@ -117,24 +116,6 @@ def clip(a, min_a, max_a):
     return a
 
 
-def get_parameters(function: Callable) -> MappingProxyType[str, inspect.Parameter]:
-    """Return the parameters of ``function`` as an ordered mapping of parameters'
-    names to their corresponding ``Parameter`` objects.
-
-    Examples
-    --------
-    ::
-
-        >>> # Skipping test because of gh-101446 (cypthon)
-        >>> get_parameters(get_parameters)  # doctest: +SKIP
-        mappingproxy(OrderedDict([('function', <Parameter "function: 'Callable'">)]))
-
-        >>> tuple(get_parameters(choose))
-        ('n', 'k')
-    """
-    return inspect.signature(function).parameters
-
-
 def sigmoid(x: float) -> float:
     r"""Returns the output of the logistic function.