Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] - check Key Pair list using aws provider #10188

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

dgaikwad
Copy link
Contributor

adding_test test to check key pair able to see or not for custom user when tenant as Parent tenant and Child - tenant

Purpose or Intent

PRT Run

{{pytest: cfme/tests/configure/test_access_control.py -k test_aws_keypair_list --long-running -v}}

@dgaikwad dgaikwad changed the title check Key Pair list on aws provider [WIPTEST] - check Key Pair list using aws provider Jun 11, 2020
@dgaikwad dgaikwad changed the title [WIPTEST] - check Key Pair list using aws provider [RFR] - check Key Pair list using aws provider Jun 11, 2020
@@ -157,6 +158,57 @@ def catalog_obj(appliance):
cat.delete()


@pytest.fixture()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parentheses aren't needed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

else:
tenant_role.product_features = [
(['Everything', 'Compute', 'Clouds', 'Auth Key Pairs'], True)
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any difference between these two values. Also, since 5.10 and earlier versions are no longer being run against master, there's no need for version checking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pytest.mark.customer_scenario
@test_requirements.rbac
@pytest.mark.tier(2)
@pytest.mark.meta(coverage=[1730066])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the automates keyword instead of coverage for automated tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dgaikwad dgaikwad changed the title [RFR] - check Key Pair list using aws provider [WIPTEST] - check Key Pair list using aws provider Jun 11, 2020
@dgaikwad dgaikwad changed the title [WIPTEST] - check Key Pair list using aws provider [RFR] - check Key Pair list using aws provider Jun 11, 2020
@dgaikwad dgaikwad changed the title [RFR] - check Key Pair list using aws provider [WIPTEST] - check Key Pair list using aws provider Jun 11, 2020
@dgaikwad dgaikwad force-pushed the test_aws_keypair_list branch 2 times, most recently from c824d1b to f8ea0f3 Compare June 11, 2020 18:03
@dgaikwad dgaikwad changed the title [WIPTEST] - check Key Pair list using aws provider [RFR] - check Key Pair list using aws provider Jun 11, 2020
provider=provider
)
assert keypair.exists
request.addfinalizer(keypair.delete)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Always better to add finalizer for create operation. I think here you can use delete_if_exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

assert keypair.exists
request.addfinalizer(keypair.delete)

view = navigate_to(appliance.collections.cloud_keypairs, 'All')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: When we have BaseEnity object you wan access CollectionEnity with parent.

navigate_to(keypair.parent, 'All')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@digitronik digitronik added the test-automation To be applied on PR's which are automating existing manual cases label Jun 16, 2020
@dgaikwad dgaikwad changed the title [RFR] - check Key Pair list using aws provider [WIPTEST] - check Key Pair list using aws provider Jun 16, 2020
@dgaikwad dgaikwad changed the title [WIPTEST] - check Key Pair list using aws provider [RFR] - check Key Pair list using aws provider Jun 16, 2020
@dgaikwad dgaikwad changed the title [RFR] - check Key Pair list using aws provider [WIPTEST] - check Key Pair list using aws provider Jun 16, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Jun 16, 2020

I detected some fixture changes in commit 60ec7f8

The local fixture tenant_custom_role is used in the following files:

  • cfme/tests/configure/test_access_control.py
    • test_aws_keypair_list

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dgaikwad dgaikwad changed the title [WIPTEST] - check Key Pair list using aws provider [RFR] - check Key Pair list using aws provider Jun 16, 2020
@digitronik digitronik self-assigned this Jun 18, 2020
@digitronik digitronik changed the title [RFR] - check Key Pair list using aws provider [1LP][RFR] - check Key Pair list using aws provider Jun 18, 2020
@digitronik digitronik merged commit ec6d9c3 into ManageIQ:master Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants