This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] - Test to check edit option for existing group #10120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
e7dbe78
to
954ae36
Compare
dgaikwad
changed the title
jarovo
reviewed
May 18, 2020
| # Selecting first row from all group | ||
| row = view.table[0] | ||
| row[0].check() | ||
| assert row[0].checked |
There was a problem hiding this comment.
Is this bit redundant? I think it is browser's job to keep the element checked once it was checked. We don't check these things and take them as granted working.
If there was a problem that this got unchecked by some javascript, then I believe we need some kind of wait + check or periodic checking of the checked state during some time interval anyway.
jarovo
reviewed
May 18, 2020
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
954ae36
to
4e80b1c
Compare
dgaikwad
changed the title
john-dupuy
added
the
test-automation
john-dupuy
suggested changes
May 19, 2020
tpapaioa
reviewed
May 20, 2020
| failure_patterns=[msg]).waiting(timeout=120): | ||
|
|
||
| # Selecting first row from all group | ||
| row = view.table[0] |
There was a problem hiding this comment.
The docstring description and the testSteps and expectedResults sections indicate that the test should be for a custom group, and that the option is called 'Edit Group'. But the test clicks on the first group in the list of all groups, which is probably going to be the default group EvmGroup-administrator, not a custom group, and the option is 'Edit the selected Group'.
There was a problem hiding this comment.
The docstring description and expectedResults are still wrong:
Should be able to see "edit group" option for existing group after selecting the group
and
2. Able to see Edit Group option
The option is Edit the selected Group, not edit group or Edit Group.
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
4e80b1c
to
541ccbe
Compare
john-dupuy
approved these changes
May 20, 2020
john-dupuy
changed the title
dgaikwad
changed the title
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
541ccbe
to
d5292cb
Compare
dgaikwad
changed the title
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
d5292cb
to
f435fd2
Compare
dajoRH
changed the title
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
f435fd2
to
9f4b951
Compare
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
9f4b951
to
3cf10c8
Compare
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
3cf10c8
to
2ca2b17
Compare
dgaikwad
force-pushed
the
test_select_edit_group
branch
from
2ca2b17
to
d73ddb2
Compare
dgaikwad
changed the title
mshriver
approved these changes
May 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/configure/test_access_control.py -k "test_select_edit_group" -v}}