Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] - Removing duplicate test #10106

Merged
merged 1 commit into from
May 15, 2020

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented May 10, 2020

Removed duplicate test case

Purpose or Intent

PRT Run

@dgaikwad dgaikwad changed the title [WIPTEST] - Test to new user login on SSUI [RFR] - Test to new user login on SSUI May 10, 2020
Comment on lines 2818 to 2822
user, _ = user_self_service_role

with user:
with appliance.context.use(ViaSSUI):
appliance.server.login(user)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It kinda looks like a smoke test. If you think so too, better to add a smoke test marker.

@valaparthvi valaparthvi added the test-automation To be applied on PR's which are automating existing manual cases label May 11, 2020
@niyazRedhat
Copy link
Contributor

We already have automation covered for this senario

@john-dupuy
Copy link
Contributor

john-dupuy commented May 12, 2020

@dgaikwad This could be easily parametrized and combined with #10105, but as @niyazRedhat if we already have coverage for this scenario we should just remove this test case.

@niyazRedhat can you provide a link?

@dgaikwad
Copy link
Contributor Author

@niyazRedhat Thanks for your suggestion. @john-dupuy found this test which is doing same:

def test_custom_button_role_access_service(

@dgaikwad dgaikwad force-pushed the test_self_service_users_ssui branch from 6f03d35 to 826ad3e Compare May 13, 2020 09:13
@dgaikwad dgaikwad changed the title [RFR] - Test to new user login on SSUI [WIPTEST] - Test to new user login on SSUI May 13, 2020
@dgaikwad dgaikwad force-pushed the test_self_service_users_ssui branch from 826ad3e to 72cb93a Compare May 13, 2020 09:14
@dgaikwad dgaikwad force-pushed the test_self_service_users_ssui branch from 72cb93a to 9a6641b Compare May 13, 2020 09:15
@dgaikwad dgaikwad changed the title [WIPTEST] - Test to new user login on SSUI [RFR] - Removing duplicate test May 13, 2020
@dgaikwad dgaikwad requested a review from valaparthvi May 13, 2020 11:54
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update the PR description with the test that provides coverage for this scenario.

@valaparthvi valaparthvi changed the title [RFR] - Removing duplicate test [1LP][RFR] - Removing duplicate test May 14, 2020
@valaparthvi valaparthvi added test-cleanup Test removal, collection changes, re-organization and removed test-automation To be applied on PR's which are automating existing manual cases labels May 14, 2020
@mshriver mshriver merged commit cd8eec0 into ManageIQ:master May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-cleanup Test removal, collection changes, re-organization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants