This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Update test_vm_genealogy_detected via summary on vcenter #10096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spusateri
changed the title
spusateri
changed the title
mshriver
reviewed
May 6, 2020
| @@ -68,7 +68,7 @@ def test_vm_genealogy_detected( | |||
| vm_crud_ancestors = create_vm.genealogy.ancestors | |||
| except NameError: | |||
| logger.exception("The parent template not detected!") | |||
| raise pytest.fail("The parent template not detected!") | |||
| pytest.fail("The parent template not detected!") | |||
There was a problem hiding this comment.
As discussed, this whole try/except block may get removed with other test automation work, because there does not appear to be any path for a NameError during the call to genealogy.ancestors.
Good to clean this up to a direct pytest.fail call for now.
mshriver
approved these changes
May 6, 2020
|
@spusateri the merge commit needs to be squashed out, please use |
jawatts
changed the title
test cleanup simplify test failure call Update test_vm_genealogy_detected via summary on vcenter test cleanup clean up Update test_vm_genealogy_detected via summary on vcenter test cleanup simplify test failure call Update test_vm_genealogy_detected via summary on vcenter test cleanup
spusateri
force-pushed
the
fix_genealogy_automation
branch
from
da0d513
to
a523e16
Compare
jawatts
approved these changes
May 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run