[1LP][RFR] Quota test fixes

[tpapaioa]

This PR makes some changes to quota tests, including:

1.) Renamed fixtures for readability and clarity:

roottenant -> root_tenant
set_roottenant_quota -> set_root_tenant_quota
check_hosts -> migration_destination_host

2.) Use create_vm_modscope fixture when provisioning VMs.
3.) Use f-strings instead of format().

One of the tests is failing in PRT, but it appears to be due to an intermittent bug in CFME that I haven't been able to reproduce reliably.

{{ pytest: -v --long-running cfme/tests/infrastructure/test_tenant_quota.py }}

[dajoRH]

I detected some fixture changes in commit 1eaf033

The local fixture set_root_tenant_quota is used in the following files:

• cfme/tests/infrastructure/test_tenant_quota.py
  • test_tenant_quota_enforce_via_lifecycle_infra
  • test_tenant_quota_enforce_via_service_infra
  • test_tenant_quota_vm_reconfigure

The local fixture migration_destination_host is used in the following files:

• cfme/tests/infrastructure/test_tenant_quota.py

The local fixture quota_limit is used in the following files:

• cfme/tests/infrastructure/test_tenant_quota.py
  • test_quota_with_reconfigure_resize_disks

The local fixture configure_mail is used in the following files:

• cfme/tests/infrastructure/test_tenant_quota.py
  • test_quota_exceed_mail_with_more_info_link

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[john-dupuy]

PRT failures do not appear to be related to this PR.