-
Notifications
You must be signed in to change notification settings - Fork 164
[1LP][RFR] Fix test_embedded_ansible_actions #10037
Conversation
afabd78
to
aaa49c1
Compare
aaa49c1
to
54a0398
Compare
54a0398
to
46714a5
Compare
46714a5
to
813bf32
Compare
1442121
to
ce1c90e
Compare
ce1c90e
to
0528eee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, if you agree, make sure to change it everywhere. LGTM otherwise.
0528eee
to
6988abb
Compare
I detected some fixture changes in commit 6988abb The local fixture
The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
def test_action_run_ansible_playbook_localhost(request, ansible_catalog_item, ansible_action, | ||
policy_for_testing, create_vm_modscope, ansible_credential, ansible_service_request, | ||
ansible_service): | ||
@pytest.mark.parametrize("create_vm_modscope", ["full_template"], indirect=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you apply black formatting to the module in a PR that is fixing the test, its hard to tell what is actually changing test behavior and what's just auto-formatted.
Please, in future PRs, refrain from including auto-formatting changes along with functional changes.
pre-commit config is excluding black formatting from most of the repo - if you're interested in including more of the repository in our auto-formatting, that's great! Just open separate PRs updating the pre-commit configuration for black, and applying it to the given directories.
Otherwise the next person that modifies this file won't be adhering to the same formatting as what you've applied here.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/ansible/test_embedded_ansible_actions.py --long-running }}