Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fix test_embedded_ansible_actions #10037

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

Gauravtalreja1
Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 commented Apr 3, 2020

Purpose or Intent

PRT Run

{{pytest: cfme/tests/ansible/test_embedded_ansible_actions.py --long-running }}

@Gauravtalreja1 Gauravtalreja1 force-pushed the fix-ansible-actions branch 4 times, most recently from afabd78 to aaa49c1 Compare April 6, 2020 09:56
@dajoRH dajoRH added needs-lint and removed lint-ok labels Apr 6, 2020
@dajoRH dajoRH added lint-ok and removed needs-lint labels Apr 6, 2020
@dajoRH dajoRH added needs-lint and removed lint-ok labels Apr 9, 2020
@dajoRH dajoRH added lint-ok and removed needs-lint labels Apr 9, 2020
@Gauravtalreja1 Gauravtalreja1 force-pushed the fix-ansible-actions branch 3 times, most recently from 1442121 to ce1c90e Compare April 17, 2020 06:29
@Gauravtalreja1 Gauravtalreja1 changed the title [WIPTEST] Fix test_embedded_ansible_actions [RFR] Fix test_embedded_ansible_actions Apr 21, 2020
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, if you agree, make sure to change it everywhere. LGTM otherwise.

cfme/tests/ansible/test_embedded_ansible_actions.py Outdated Show resolved Hide resolved
@dajoRH
Copy link
Contributor

dajoRH commented Apr 22, 2020

I detected some fixture changes in commit 6988abb

The local fixture ansible_action is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_actions.py
    • policy_for_testing

The local fixture policy_for_testing is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_actions.py

The local fixture ansible_credential is used in the following files:

  • cfme/tests/ansible/test_embedded_ansible_actions.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@ganeshhubale ganeshhubale changed the title [RFR] Fix test_embedded_ansible_actions [1LP][RFR] Fix test_embedded_ansible_actions Apr 22, 2020
@mshriver mshriver self-assigned this Apr 22, 2020
def test_action_run_ansible_playbook_localhost(request, ansible_catalog_item, ansible_action,
policy_for_testing, create_vm_modscope, ansible_credential, ansible_service_request,
ansible_service):
@pytest.mark.parametrize("create_vm_modscope", ["full_template"], indirect=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you apply black formatting to the module in a PR that is fixing the test, its hard to tell what is actually changing test behavior and what's just auto-formatted.

Please, in future PRs, refrain from including auto-formatting changes along with functional changes.

pre-commit config is excluding black formatting from most of the repo - if you're interested in including more of the repository in our auto-formatting, that's great! Just open separate PRs updating the pre-commit configuration for black, and applying it to the given directories.

Otherwise the next person that modifies this file won't be adhering to the same formatting as what you've applied here.

@mshriver mshriver merged commit ae167e6 into ManageIQ:master Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants