Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative values for bounds in SFS are not recognised #52

Closed
jackaraz opened this issue Mar 18, 2022 · 1 comment · Fixed by #64
Closed

Negative values for bounds in SFS are not recognised #52

jackaraz opened this issue Mar 18, 2022 · 1 comment · Fixed by #64
Assignees
Labels
🐛bug Something isn't working NormalMode Normal Mode SFS Simplified detector simulation in MadAnalysis 5

Comments

@jackaraz
Copy link
Member

System Settings

System settings:

  • OS: macOS 12.3
  • Python version 3.8.9
  • gcc/c++ version Apple clang version 13.1.6 (clang-1316.0.21.2)
  • MA5: MA5 release : 1.10.2 [ 2022/02/15 ]
  • FastJet 3.3.3

Describe the bug

Negative values in SFS bound declaration are not recognized.

To Reproduce

./bin/ma5 -R
set main.fastsim.package = fastjet
define reco_efficiency mu 0.9 [ eta < -1 ]

Error message:

MA5-ERROR: Incorrect formula (ignoring the line): [LEAF[ ETA: { id:0 }], OP[ -: { id:2 }]]
MA5: ast nr. 0
MA5: leaves = 4
MA5:   ** Leaf nr. 0
MA5:     -> type/name = var (ETA)
MA5:     -> mother: []
MA5:     -> daugthers: []
MA5:   ** Leaf nr. 1
MA5:     -> type/name = bin1_op (<)
MA5:     -> mother: [2]
MA5:     -> daugthers: []
MA5:   ** Leaf nr. 2
MA5:     -> type/name = bin1_op (-)
MA5:     -> mother: []
MA5:     -> daugthers: [1, 3]
MA5:   ** Leaf nr. 3
MA5:     -> type/name = cst (1)
MA5:     -> mother: [2]
MA5:     -> daugthers: []

Expected behaviour

-1 Should have been registered as a constant instead of a binary operator.

Log files

No response

Additional information

No response

@jackaraz jackaraz added 🐛bug Something isn't working SFS Simplified detector simulation in MadAnalysis 5 NormalMode Normal Mode labels Mar 18, 2022
BFuks added a commit that referenced this issue Apr 5, 2022
@BFuks BFuks mentioned this issue Apr 5, 2022
@BFuks
Copy link
Member

BFuks commented Apr 5, 2022

This bug has been fixed. Review required (#64)

@jackaraz jackaraz linked a pull request Apr 5, 2022 that will close this issue
jackaraz added a commit that referenced this issue Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working NormalMode Normal Mode SFS Simplified detector simulation in MadAnalysis 5
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants