Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Use new scaler to retain original unaltered scaler #33

Merged
merged 1 commit into from
Feb 24, 2021
Merged

[FIX] Use new scaler to retain original unaltered scaler #33

merged 1 commit into from
Feb 24, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 23, 2021

Closes #30.

Changes proposed:

  • When variance-normalizing subsampled data, use a temporary scaler instead of the object's primary scaler, because fit_transforming a scaler overwrites the mean and std attributes that are necessary for rescaling the data in inverse_transform.

@tsalo tsalo requested a review from eurunuela February 23, 2021 23:46
@notZaki
Copy link
Collaborator

notZaki commented Feb 23, 2021

An alternative could be to use scale(dat, axis = 2) for one-off usage.

@eurunuela eurunuela merged commit 81bca85 into ME-ICA:main Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaler parameters overridden within MovingAveragePCA
3 participants
@tsalo @notZaki @eurunuela