Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

game-string: manage game strings in libtrx #1526

Merged
merged 3 commits into from
Sep 17, 2024
Merged

game-string: manage game strings in libtrx #1526

merged 3 commits into from
Sep 17, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 17, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

…

@rr- rr- added Internal The invisible stuff Priority: high This has a high impact on the core gameplay, or blocks other work. labels Sep 17, 2024
@rr- rr- added this to the 4.4 milestone Sep 17, 2024
@rr- rr- self-assigned this Sep 17, 2024
@rr- rr- requested review from a team as code owners September 17, 2024 21:21
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team September 17, 2024 21:21
@rr- rr- mentioned this pull request Sep 17, 2024
Merged
walkawayy
walkawayy approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@walkawayy walkawayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing looks good for options, controls, stats, and final stats!

@rr- rr- merged commit 823a45d into develop Sep 17, 2024
5 of 6 checks passed
@rr- rr- deleted the libtrx-game-strings branch September 17, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walkawayy walkawayy walkawayy approved these changes

@lahm86 lahm86 Awaiting requested review from lahm86 lahm86 is a code owner automatically assigned from LostArtefacts/dev

@aredfan aredfan Awaiting requested review from aredfan aredfan is a code owner automatically assigned from LostArtefacts/qa

Assignees

@rr- rr-

Labels
Internal The invisible stuff Priority: high This has a high impact on the core gameplay, or blocks other work.
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@rr- @walkawayy