Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transfer history #623

Merged
merged 69 commits into from
May 31, 2022
Merged

Feature/transfer history #623

merged 69 commits into from
May 31, 2022

Conversation

vectorman1
Copy link
Contributor

Detailed description:

Which issue(s) this PR fixes:
Fixes #619

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #623 (864e891) into main (84b7c8a) will decrease coverage by 0.43%.
The diff coverage is 76.89%.

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   63.96%   63.52%   -0.44%     
==========================================
  Files          75       76       +1     
  Lines        5356     5440      +84     
==========================================
+ Hits         3426     3456      +30     
- Misses       1783     1832      +49     
- Partials      147      152       +5     
Flag Coverage Δ
unittests 63.52% <76.89%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/helper/http/error-response.go 0.00% <0.00%> (ø)
app/process/watcher/evm/watcher.go 35.24% <0.00%> (ø)
app/services/bridge-config/service.go 88.60% <ø> (ø)
app/router/transfer/transfer.go 32.07% <15.38%> (-67.93%) ⬇️
app/services/lock-event/service.go 13.96% <50.00%> (ø)
app/process/watcher/transfer/watcher.go 46.15% <60.00%> (ø)
.../process/handler/read-only/fee-transfer/handler.go 17.10% <75.00%> (ø)
app/persistence/transfer/transfer.go 91.61% <87.01%> (-5.45%) ⬇️
app/persistence/fee/fee.go 97.67% <100.00%> (ø)
app/persistence/message/message.go 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b7c8a...864e891. Read the comment docs.

svetlio8
svetlio8 previously approved these changes May 24, 2022
app/persistence/message/message.go Outdated Show resolved Hide resolved
app/persistence/transfer/transfer.go Outdated Show resolved Hide resolved
app/model/transfer/transfer.go Show resolved Hide resolved
Signed-off-by: Boris Lachev <[email protected]>
svetlio8
svetlio8 previously approved these changes May 27, 2022
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
@failfmi failfmi self-requested a review May 31, 2022 10:27
@vectorman1 vectorman1 merged commit 4c7e2fa into main May 31, 2022
@vectorman1 vectorman1 deleted the feature/transfer-history branch May 31, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET /transfer-history
4 participants