Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WarningCache to subclass set #7995

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Tiny change. Should be okay as we don't access warnings anywhere

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the feature Is an improvement or enhancement label Jun 16, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 16, 2021
@carmocca carmocca self-assigned this Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #7995 (a055375) into master (b71aa55) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7995    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         207     207            
  Lines       13375   13375            
=======================================
- Hits        12245   11607   -638     
- Misses       1130    1768   +638     

@kaushikb11 kaushikb11 enabled auto-merge (squash) June 16, 2021 08:32
@carmocca carmocca added the ready PRs ready to be merged label Jun 16, 2021
@kaushikb11 kaushikb11 merged commit 2134216 into master Jun 16, 2021
@kaushikb11 kaushikb11 deleted the feat/warning-cache-subclass-set branch June 16, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants