Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix myst-parser warning blocking docs ci #7967

Merged
merged 5 commits into from
Jun 14, 2021
Merged

fix myst-parser warning blocking docs ci #7967

merged 5 commits into from
Jun 14, 2021

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Jun 14, 2021

What does this PR do?

The CI on master is failing with the docs make job in CI failing with the warning

WARNING: `mathjax3_config['options']['processHtmlClass']` is being overridden by myst-parser to tex2jax_process|mathjax_process|math. Set `myst_mathjax_classes = None` if this is undesirable.

This PR unblocks master from merging PRs.

Issue opened on myst-parser: executablebooks/MyST-Parser#394

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Jun 14, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #7967 (80ea31b) into master (f15ea60) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7967   +/-   ##
======================================
- Coverage      91%     91%   -0%     
======================================
  Files         203     203           
  Lines       13129   13129           
======================================
- Hits        11992   11979   -13     
- Misses       1137    1150   +13     

Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:hand_with_index_and_middle_fingers_crossed: 

@Borda Borda added 3rd party Related to a 3rd-party docs Documentation related priority: 1 Medium priority task ready PRs ready to be merged labels Jun 14, 2021
@awaelchli awaelchli enabled auto-merge (squash) June 14, 2021 10:24
@awaelchli
Copy link
Member Author

docker failing with no space left on device, seems unrelated to this PR. everything else looks ok

@awaelchli awaelchli merged commit 20a5e09 into master Jun 14, 2021
@awaelchli awaelchli deleted the ci/myst-parser branch June 14, 2021 11:17
@carmocca carmocca mentioned this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party ci Continuous Integration docs Documentation related priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants