Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TPU Spawn gather #6896

Merged
merged 9 commits into from
Apr 9, 2021
Merged

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Apr 8, 2021

What does this PR do?

Fixes #6895

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added bug Something isn't working accelerator: tpu Tensor Processing Unit labels Apr 8, 2021
@kaushikb11 kaushikb11 added this to the 1.2.x milestone Apr 8, 2021
@kaushikb11 kaushikb11 self-assigned this Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #6896 (57dc10e) into master (e35192d) will decrease coverage by 5%.
The diff coverage is 33%.

@@           Coverage Diff           @@
##           master   #6896    +/-   ##
=======================================
- Coverage      91%     87%    -5%     
=======================================
  Files         194     194            
  Lines       12350   12477   +127     
=======================================
- Hits        11300   10807   -493     
- Misses       1050    1670   +620     

@kaushikb11 kaushikb11 changed the title Fix TPU Spawn Fix TPU Spawn gather Apr 8, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review April 8, 2021 21:12
@kaushikb11 kaushikb11 added the priority: 0 High priority task label Apr 9, 2021
@mergify mergify bot removed the has conflicts label Apr 9, 2021
@kaushikb11 kaushikb11 merged commit 5552503 into Lightning-AI:master Apr 9, 2021
@kaushikb11 kaushikb11 deleted the tpu/priority branch April 9, 2021 13:01
@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
(cherry picked from commit 5552503)
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
(cherry picked from commit 5552503)
lexierule pushed a commit that referenced this pull request Apr 14, 2021
(cherry picked from commit 5552503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError: dimension specified as 0 but tensor has no dimensions
5 participants