Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update sync_dist warning for multiple processes #6790

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

sync_fn is not a parameter for self.log.

Related to #6716

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added this to the 1.2.x milestone Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #6790 (f4e09fb) into master (13f67ad) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6790    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         192     192            
  Lines       12174   12224    +50     
=======================================
- Hits        11147   10614   -533     
- Misses       1027    1610   +583     

@kaushikb11 kaushikb11 added the ready PRs ready to be merged label Apr 2, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carmocca carmocca added the docs Documentation related label Apr 5, 2021
@mergify mergify bot requested a review from a team April 6, 2021 07:34
@Borda Borda changed the title Update sync_dist warning for multiple processes docs: Update sync_dist warning for multiple processes Apr 6, 2021
@Borda Borda requested review from carmocca and tchaton April 6, 2021 09:43
@carmocca carmocca merged commit a17c027 into Lightning-AI:master Apr 6, 2021
@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants