Fixed Review

Leoche · Sep 29, 2020 · 71a83e5 · 71a83e5
1 parent 9b68056
commit 71a83e5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/Core/Domain/Cart/Command/RemoveCartRuleFromCartCommand.php b/src/Core/Domain/Cart/Command/RemoveCartRuleFromCartCommand.php
@@ -26,6 +26,7 @@
 
 namespace PrestaShop\PrestaShop\Core\Domain\Cart\Command;
 
+use PrestaShop\PrestaShop\Core\Domain\Cart\Exception\CartConstraintException;
 use PrestaShop\PrestaShop\Core\Domain\Cart\ValueObject\CartId;
 use PrestaShop\PrestaShop\Core\Domain\CartRule\ValueObject\CartRuleId;
 
@@ -48,7 +49,7 @@ class RemoveCartRuleFromCartCommand
      * @param int $cartId
      * @param int $cartRuleId
      *
-     * @throws \PrestaShop\PrestaShop\Core\Domain\Cart\Exception\CartConstraintException
+     * @throws CartConstraintException
      */
     public function __construct(int $cartId, int $cartRuleId)
     {

diff --git a/src/Core/Kpi/Row/HookableKpiRowFactory.php b/src/Core/Kpi/Row/HookableKpiRowFactory.php
@@ -73,7 +73,7 @@ public function __construct(
     }
 
     /**
-     * @return KpiRow|KpiRowInterface|void
+     * @return KpiRow|void
      *
      * @throws InvalidArgumentException
      */

diff --git a/src/PrestaShopBundle/Event/Dispatcher/NullDispatcher.php b/src/PrestaShopBundle/Event/Dispatcher/NullDispatcher.php
@@ -28,6 +28,8 @@
 
 use PrestaShop\PrestaShop\Core\Hook\HookDispatcherInterface;
 use PrestaShop\PrestaShop\Core\Hook\HookInterface;
+use PrestaShop\PrestaShop\Core\Hook\RenderedHookInterface;
+use Symfony\Component\EventDispatcher\Event;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 
@@ -43,11 +45,11 @@ public function addSubscriber(EventSubscriberInterface $subscriber)
 
     /**
      * @param string $eventName
-     * @param \Symfony\Component\EventDispatcher\Event|null $event
+     * @param Event|null $event
      *
-     * @return \Symfony\Component\EventDispatcher\Event|void
+     * @return Event|void
      */
-    public function dispatch($eventName, \Symfony\Component\EventDispatcher\Event $event = null)
+    public function dispatch($eventName, Event $event = null)
     {
     }
 
@@ -98,7 +100,7 @@ public function dispatchWithParameters($hookName, array $hookParameters = [])
     /**
      * @param HookInterface $hook
      *
-     * @return \PrestaShop\PrestaShop\Core\Hook\RenderedHookInterface|void
+     * @return RenderedHookInterface|void
      */
     public function dispatchRendering(HookInterface $hook)
     {
@@ -108,7 +110,7 @@ public function dispatchRendering(HookInterface $hook)
      * @param string $hookName
      * @param array $hookParameters
      *
-     * @return \PrestaShop\PrestaShop\Core\Hook\RenderedHookInterface|void
+     * @return RenderedHookInterface|void
      */
     public function dispatchRenderingWithParameters($hookName, array $hookParameters = [])
     {