Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some "standard" JoinConfiguration instances #466

Closed
kezz opened this issue Oct 4, 2021 · 0 comments · Fixed by #482
Closed

Add some "standard" JoinConfiguration instances #466

kezz opened this issue Oct 4, 2021 · 0 comments · Fixed by #482
Labels
area: api good first issue type: enhancement

Comments

@kezz
Copy link
Member

kezz commented Oct 4, 2021

For example:

  • newlines
  • comma separated
  • traditional "list"
lynxplay added a commit to lynxplay/adventure that referenced this issue Oct 24, 2021
@lynxplay
Add standard join configurations
edd71d8 
While using join configurations is already rather simple, they tend to
clutter up already rather verbose source code. While the initial
creation of the JoinConfiguration already included a null configuration,
accessible through 'JoinConfiguration#noSeparators', other standards or
often used layouts were not added.

This commit adds three more defaults/standards to the join configuration
implementation that are exposed through static accessors in the join
configuration interface.
Specifically:

newLines:
  A straight forward instance of the join configuraiton that uses the
  new line component to join together components.

commas:
  Another straight forward instance of the join configuration that uses
  a single comma to join together components, creating a CSV like
  layout.

arrayLike:
  A more complex join configuration that recreates the layout used by
  the java.util.Arrays#toString method.

Resolves: KyoriPowered#466
@lynxplay lynxplay mentioned this issue Oct 24, 2021
Merged
lynxplay added a commit to lynxplay/adventure that referenced this issue Oct 24, 2021
@lynxplay
Add standard join configurations
ee77198 
While using join configurations is already rather simple, they tend to
clutter up already rather verbose source code. While the initial
creation of the JoinConfiguration already included a null configuration,
accessible through 'JoinConfiguration#noSeparators', other standards or
often used layouts were not added.

This commit adds three more defaults/standards to the join configuration
implementation that are exposed through static accessors in the join
configuration interface.
Specifically:

newLines:
  A straight forward instance of the join configuraiton that uses the
  new line component to join together components.

commas:
  Another straight forward instance of the join configuration that uses
  a single comma to join together components, creating a CSV like
  layout.

arrayLike:
  A more complex join configuration that recreates the layout used by
  the java.util.Arrays#toString method.

Resolves: KyoriPowered#466
lynxplay added a commit to lynxplay/adventure that referenced this issue Oct 24, 2021
@lynxplay
Add standard join configurations
4e565d4 
While using join configurations is already rather simple, they tend to
clutter up already rather verbose source code. While the initial
creation of the JoinConfiguration already included a null configuration,
accessible through 'JoinConfiguration#noSeparators', other standards or
often used layouts were not added.

This commit adds three more defaults/standards to the join configuration
implementation that are exposed through static accessors in the join
configuration interface.
Specifically:

newLines:
  A straight forward instance of the join configuraiton that uses the
  new line component to join together components.

commas:
  Another straight forward instance of the join configuration that uses
  a single comma to join together components, creating a CSV like
  layout.

arrayLike:
  A more complex join configuration that recreates the layout used by
  the java.util.Arrays#toString method.

Resolves: KyoriPowered#466
lynxplay added a commit to lynxplay/adventure that referenced this issue Oct 24, 2021
@lynxplay
Add standard join configurations
5d4384a 
While using join configurations is already rather simple, they tend to
clutter up already rather verbose source code. While the initial
creation of the JoinConfiguration already included a null configuration,
accessible through 'JoinConfiguration#noSeparators', other standards or
often used layouts were not added.

This commit adds three more defaults/standards to the join configuration
implementation that are exposed through static accessors in the join
configuration interface.
Specifically:

newLines:
  A straight forward instance of the join configuraiton that uses the
  new line component to join together components.

commas:
  Another straight forward instance of the join configuration that uses
  a single comma (or potentially a comma and a space) to join together
  components.

arrayLike:
  A more complex join configuration that recreates the layout used by
  the java.util.Arrays#toString method.

Resolves: KyoriPowered#466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api good first issue type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add standard join configurations lynxplay/adventure
2 participants
@kezz and others