-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Infinite loading of the live trade history #2712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## dev #2712 +/- ##
==========================================
+ Coverage 51.27% 51.29% +0.01%
==========================================
Files 382 382
Lines 11540 11546 +6
Branches 2757 2749 -8
==========================================
+ Hits 5917 5922 +5
+ Misses 5400 5394 -6
- Partials 223 230 +7
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Marko-roy
previously approved these changes
Jul 31, 2023
avclarke
reviewed
Jul 31, 2023
platschi
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
react-table
. This PR restores the functionality of the loading infinite loading work.TradeBalance
Related issue
Fixed the bug introduced by #2592
Motivation and Context
How Has This Been Tested?
Go to the market page and scroll down the live trade history.
The infinite loading of the live trade history now functions as expected.
Screenshots (if appropriate):