Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): add new markets #2697

Merged
merged 9 commits into from
Jul 28, 2023
Merged

chore(*): add new markets #2697

merged 9 commits into from
Jul 28, 2023

Conversation

platschi
Copy link
Collaborator

@platschi platschi commented Jul 27, 2023

Description

@platschi platschi requested a review from avclarke July 27, 2023 14:22
@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jul 28, 2023 1:22pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jul 28, 2023 1:22pm

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2697 (de64b03) into dev (bfc59bd) will increase coverage by 0.11%.
Report is 11 commits behind head on dev.
The diff coverage is 76.00%.

@@            Coverage Diff             @@
##              dev    #2697      +/-   ##
==========================================
+ Coverage   51.27%   51.38%   +0.11%     
==========================================
  Files         382      382              
  Lines       11540    11538       -2     
  Branches     2757     2745      -12     
==========================================
+ Hits         5917     5929      +12     
+ Misses       5400     5385      -15     
- Partials      223      224       +1     
Files Changed Coverage Δ
packages/app/src/components/TVChart/DataFeed.ts 21.79% <ø> (+3.04%) ⬆️
...ions/futures/MobileTrade/UserTabs/PositionsTab.tsx 64.10% <0.00%> (ø)
packages/app/src/utils/futures.ts 58.45% <ø> (-0.58%) ⬇️
packages/app/src/queries/rates/utils.ts 30.76% <28.57%> (-2.57%) ⬇️
packages/app/src/components/TVChart/TVChart.tsx 62.31% <100.00%> (+0.55%) ⬆️
packages/app/src/queries/rates/constants.ts 66.66% <100.00%> (+6.66%) ⬆️
...ages/app/src/queries/rates/useCandlesticksQuery.ts 32.00% <100.00%> (ø)
...ackages/app/src/sections/futures/PositionChart.tsx 82.35% <100.00%> (+0.53%) ⬆️
...ions/futures/ProfitCalculator/ProfitCalculator.tsx 21.27% <100.00%> (ø)
...rc/sections/futures/ShareModal/AmountContainer.tsx 42.85% <100.00%> (-1.33%) ⬇️
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

avclarke
avclarke previously approved these changes Jul 28, 2023
@platschi platschi requested a review from LeifuChen July 28, 2023 13:19
@platschi platschi merged commit 3b09a37 into dev Jul 28, 2023
4 of 5 checks passed
@platschi platschi deleted the chore/ethbtc branch July 28, 2023 13:26
LeifuChen pushed a commit that referenced this pull request Jul 28, 2023
* chore: add ethbtc market

* Fix chart for ETH/BTC

* Use suggested decimals to determine chart scale

* Revert suggested decimals

* Tweak tv chart decimals

* fix: smart margin mobile label

* chore: add new markets

* Format ETH/BTC naming

* fix: path bug

---------

Co-authored-by: Adam Clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants