Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update the prefix of forex #2687

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fix: Update the prefix of forex #2687

merged 2 commits into from
Jul 27, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Jul 27, 2023

Description

Updated the prefix of GBP, EUR and AUD to FX instead of Crypto

Related issue

#2680
#2683

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

截屏2023-07-27 14 59 06

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jul 27, 2023 0:40am
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jul 27, 2023 0:40am

Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor other bit of clean up we could do

packages/app/src/queries/rates/useCandlesticksQuery.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2687 (f30f13c) into dev (3397a7d) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##              dev    #2687      +/-   ##
==========================================
- Coverage   51.26%   51.26%   -0.01%     
==========================================
  Files         382      382              
  Lines       11542    11544       +2     
  Branches     2758     2759       +1     
==========================================
+ Hits         5917     5918       +1     
- Misses       5402     5403       +1     
  Partials      223      223              
Files Changed Coverage Δ
...ages/app/src/queries/rates/useCandlesticksQuery.ts 28.57% <25.00%> (-1.06%) ⬇️
packages/app/src/queries/rates/constants.ts 66.66% <100.00%> (+6.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@platschi platschi merged commit 4b08cc6 into dev Jul 27, 2023
5 of 6 checks passed
@platschi platschi deleted the fix/forex-prefix branch July 27, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants