Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Take deposit/withdraw modal back to smart margin #2631

Merged
merged 9 commits into from
Jul 24, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Jul 19, 2023

Description

  1. Add the deposit/withdraw modal back to the smart margin mode.
  2. Show Locked Margin even if the user has less than 50 sUSD

Related issue

Motivation and Context

It's easy for users to bridge more sUSD and trade more in one place.

How Has This Been Tested?

Case 1. User has less than 50 sUSD

  • Click on the buttonGet sUSD to open Bridge & Swap modal to bridge more sUSD
截屏2023-07-23 12 53 19

Case 2. User has less than 50 sUSD available but has locked margin

  • Show Available Margin | Lock Margin
  • Click on the pencil button to open Deposit/Withdraw modal. The user can use Bridge & Swap to bridge more sUSD.
  • Test wallet: 0x702689d3b37151506881FA5f46Ad012e59fF9B1d
截屏2023-07-23 12 51 40

Case 2. User has more than 50 sUSD

  • Click on the pencil button to open Deposit/Withdraw modal. The user can use Bridge & Swap to bridge more sUSD.

Screenshots (if appropriate):

截屏2023-07-23 12 54 46

@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jul 22, 2023 11:44pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jul 22, 2023 11:44pm

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2631 (5d18d42) into dev (bda871a) will increase coverage by 0.01%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##              dev    #2631      +/-   ##
==========================================
+ Coverage   51.22%   51.23%   +0.01%     
==========================================
  Files         381      381              
  Lines       11511    11536      +25     
  Branches     2741     2752      +11     
==========================================
+ Hits         5896     5910      +14     
- Misses       5391     5403      +12     
+ Partials      224      223       -1     
Impacted Files Coverage Δ
...ections/futures/Trade/TransferSmartMarginModal.tsx 43.47% <43.47%> (ø)
packages/app/src/pages/market.tsx 89.62% <57.14%> (-1.56%) ⬇️
...es/app/src/sections/futures/Trade/TradeBalance.tsx 73.61% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LeifuChen LeifuChen changed the title Take deposit/withdraw modal back to smart margin Feat: Take deposit/withdraw modal back to smart margin Jul 19, 2023
@LeifuChen LeifuChen marked this pull request as draft July 21, 2023 13:21
@LeifuChen LeifuChen requested a review from platschi July 23, 2023 16:15
@platschi platschi merged commit ab2a5b8 into dev Jul 24, 2023
5 of 6 checks passed
@platschi platschi deleted the feat/add-deposit-to-smart-margin branch July 24, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants