-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Take deposit/withdraw modal back to smart margin #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## dev #2631 +/- ##
==========================================
+ Coverage 51.22% 51.23% +0.01%
==========================================
Files 381 381
Lines 11511 11536 +25
Branches 2741 2752 +11
==========================================
+ Hits 5896 5910 +14
- Misses 5391 5403 +12
+ Partials 224 223 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LeifuChen
changed the title
Take deposit/withdraw modal back to smart margin
Feat: Take deposit/withdraw modal back to smart margin
Jul 19, 2023
avclarke
reviewed
Jul 22, 2023
packages/app/src/sections/futures/Trade/TransferSmartMarginModal.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/sections/futures/Trade/TransferSmartMarginModal.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/sections/futures/Trade/TransferSmartMarginModal.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/sections/futures/Trade/TransferSmartMarginModal.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/sections/futures/Trade/TransferSmartMarginModal.tsx
Outdated
Show resolved
Hide resolved
avclarke
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
deposit/withdraw modal
back to the smart margin mode.Locked Margin
even if the user has less than 50 sUSDRelated issue
Motivation and Context
It's easy for users to bridge more sUSD and trade more in one place.
How Has This Been Tested?
Case 1. User has less than 50 sUSD
Get sUSD
to openBridge & Swap
modal to bridge more sUSDCase 2. User has less than 50 sUSD available but has locked margin
Available Margin | Lock Margin
Deposit/Withdraw
modal. The user can useBridge & Swap
to bridge more sUSD.Case 2. User has more than 50 sUSD
Deposit/Withdraw
modal. The user can useBridge & Swap
to bridge more sUSD.Screenshots (if appropriate):