Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Minor design and sdk bugs #2626

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Fix: Minor design and sdk bugs #2626

merged 3 commits into from
Jul 19, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Jul 18, 2023

Description

截屏2023-07-19 01 27 03
  • Remove the extra border on the funding period toggle dropdown
截屏2023-07-19 01 27 33
  • Remove the prefix synthetic of the token selector in the exchange page
截屏2023-07-19 01 28 58
  • Remove the tiny share icon on mobile
截屏2023-07-19 01 28 19
  • Add stats (@asherism Missing icon for stats), docs, and support icons into the footer
截屏2023-07-19 01 29 43
  • On the markets page, the table headers should have a lighter background, and the first row should always be darker. The last table row should display the bottom border line.
截屏2023-07-19 01 30 08

Related issue

Closes Kwenta/kwenta-private#42

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jul 19, 2023 8:55am
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jul 19, 2023 8:55am

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #2626 (7ee945d) into dev (c48640f) will increase coverage by 0.02%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##              dev    Kwenta/kwenta#2626      +/-   ##
==========================================
+ Coverage   51.31%   51.34%   +0.02%     
==========================================
  Files         379      381       +2     
  Lines       11475    11486      +11     
  Branches     2721     2723       +2     
==========================================
+ Hits         5888     5897       +9     
- Misses       5364     5365       +1     
- Partials      223      224       +1     
Impacted Files Coverage Δ
...src/sections/futures/MarketDetails/HoursToggle.tsx 74.35% <ø> (+1.85%) ⬆️
...ions/futures/MobileTrade/UserTabs/PositionsTab.tsx 64.10% <ø> (-0.46%) ⬇️
...es/app/src/sections/futures/Trade/TradeBalance.tsx 73.61% <ø> (ø)
...p/src/sections/futures/UserInfo/PositionsTable.tsx 67.05% <0.00%> (ø)
...c/sections/futures/MarketDetails/MarketDetails.tsx 88.50% <25.00%> (-2.09%) ⬇️
packages/app/src/assets/svg/app/docs.svg 50.00% <50.00%> (ø)
packages/app/src/assets/svg/app/support.svg 50.00% <50.00%> (ø)
...pp/src/sections/shared/Layout/AppLayout/Footer.tsx 85.00% <100.00%> (+2.64%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

avclarke
avclarke previously approved these changes Jul 19, 2023
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work catching the formatPercent bug

@LeifuChen LeifuChen merged commit 7930cca into dev Jul 19, 2023
5 of 6 checks passed
@LeifuChen LeifuChen deleted the fix/design-bugs branch July 19, 2023 09:04
insulineru pushed a commit that referenced this pull request Jul 24, 2023
* Fixed various design bugs and sdk formatting issue

* Removed the unecessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants