-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Blank space under banner after network switching and V1 staked escrowed balance #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avclarke
approved these changes
Jul 15, 2023
Codecov Report
@@ Coverage Diff @@
## dev #2605 +/- ##
=======================================
Coverage 50.73% 50.73%
=======================================
Files 378 378
Lines 11381 11382 +1
Branches 2683 2683
=======================================
+ Hits 5774 5775 +1
Misses 5386 5386
Partials 221 221
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LeifuChen
added a commit
that referenced
this pull request
Jul 15, 2023
LeifuChen
added a commit
that referenced
this pull request
Jul 15, 2023
V7.4.2 (#2607) * Fix: Blank space under banner after network switching and V1 staked escrowed balance (#2605) Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance * Update the pyth trading view endpoint (#2606) Co-authored-by: Ralf <[email protected]>
insulineru
pushed a commit
that referenced
this pull request
Jul 24, 2023
…scrowed balance (#2605) Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance
insulineru
pushed a commit
that referenced
this pull request
Jul 24, 2023
V7.4.2 (#2607) * Fix: Blank space under banner after network switching and V1 staked escrowed balance (#2605) Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance * Update the pyth trading view endpoint (#2606) Co-authored-by: Ralf <[email protected]>
insulineru
pushed a commit
that referenced
this pull request
Jul 25, 2023
V7.4.2 (#2607) * Fix: Blank space under banner after network switching and V1 staked escrowed balance (#2605) Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance * Update the pyth trading view endpoint (#2606) Co-authored-by: Ralf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<Header />
component is rendered. After the network is switched, the<Container />
and<Banner />
components are processed as two separate items in the grid layout, which causesDesktopGridContainer
(grid-template: auto 1fr auto / 100%;
) to display an unexpected layout.Related issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
No blank space after network switching
Add unstaked escrowed info for v1 balance