Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Blank space under banner after network switching and V1 staked escrowed balance #2605

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Jul 15, 2023

Description

  1. This is a bug found in yesterday's test: a blank space may appear between the banner and the page content if the page content does not fill the screen (e.g. migration page and escrow tab, staking tab is unaffected) after switching the network.
    image
  • The root cause is unclear, but it seems to be related to how the <Header /> component is rendered. After the network is switched, the <Container /> and <Banner /> components are processed as two separate items in the grid layout, which causes DesktopGridContainer (grid-template: auto 1fr auto / 100%;) to display an unexpected layout.
  1. Add V1 staked escrowed balance into the Escrow tab info box
    image

Related issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

No blank space after network switching
image

Add unstaked escrowed info for v1 balance
image

@vercel
Copy link

vercel bot commented Jul 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jul 15, 2023 6:10am
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jul 15, 2023 6:10am

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #2605 (2b300eb) into dev (49408b4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #2605   +/-   ##
=======================================
  Coverage   50.73%   50.73%           
=======================================
  Files         378      378           
  Lines       11381    11382    +1     
  Branches     2683     2683           
=======================================
+ Hits         5774     5775    +1     
  Misses       5386     5386           
  Partials      221      221           
Impacted Files Coverage Δ
...sections/shared/Layout/AppLayout/Header/Header.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LeifuChen LeifuChen merged commit 7bc79ff into dev Jul 15, 2023
5 checks passed
@LeifuChen LeifuChen deleted the fix/notificaiton-banner-add-unstaked-escrow branch July 15, 2023 06:18
LeifuChen added a commit that referenced this pull request Jul 15, 2023
* Fix: Blank space under banner after network switching and V1 staked escrowed balance (#2605)

Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance

* Update the pyth trading view endpoint (#2606)
LeifuChen added a commit that referenced this pull request Jul 15, 2023
V7.4.2 (#2607)

* Fix: Blank space under banner after network switching and V1 staked escrowed balance (#2605)

Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance

* Update the pyth trading view endpoint (#2606)

Co-authored-by: Ralf <[email protected]>
insulineru pushed a commit that referenced this pull request Jul 24, 2023
…scrowed balance (#2605)

Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance
insulineru pushed a commit that referenced this pull request Jul 24, 2023
V7.4.2 (#2607)

* Fix: Blank space under banner after network switching and V1 staked escrowed balance (#2605)

Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance

* Update the pyth trading view endpoint (#2606)

Co-authored-by: Ralf <[email protected]>
insulineru pushed a commit that referenced this pull request Jul 25, 2023
V7.4.2 (#2607)

* Fix: Blank space under banner after network switching and V1 staked escrowed balance (#2605)

Fixed the banner white space in escrow tab and added v1 unstaked escrowed balance

* Update the pyth trading view endpoint (#2606)

Co-authored-by: Ralf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants